Skip to content

Fix cancellation of trainings

Álvaro López García requested to merge test_fixes_async_process2 into master

If a user performed a training -> cancel -> training -> cancel, the last cancel did not terminate properly and the API blocked, as the process did not join.

Since we are using a process pool with only 1 slot, we can get the running processes in the pool and kill them.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Merge request reports